Refactoring tab visibility - use decorator instead of helper #14349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncounter
force-pushed
the
refactoring-tab-visibility
branch
4 times, most recently
from
ca7cdfc
to
9fcd487
Compare
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
9fcd487
to
71b4ed9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14349 +/- ##
==========================================
- Coverage 87.21% 87.19% -0.03%
==========================================
Files 743 744 +1
Lines 24966 24988 +22
==========================================
+ Hits 21774 21788 +14
- Misses 3192 3200 +8 |
hellcp-work
reviewed
May 19, 2023
hennevogel
requested changes
May 22, 2023
hellcp-work
force-pushed
the
refactoring-tab-visibility
branch
2 times, most recently
from
b3858f8
to
6f1561b
Compare
danidoni
approved these changes
May 29, 2023
This was referenced Jun 7, 2023
|
@hennevogel do you miss something for this PR to be approved? |
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
d5a2757
to
e86ca5e
Compare
hennevogel
requested changes
Jun 29, 2023
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
b6398e4
to
dd67606
Compare
danidoni
reviewed
Jun 29, 2023
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
dd67606
to
8ab67db
Compare
danidoni
approved these changes
Jun 30, 2023
hennevogel
approved these changes
Jun 30, 2023
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
8ab67db
to
ca1d288
Compare
ncounter
force-pushed
the
refactoring-tab-visibility
branch
from
ca1d288
to
7cf0344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing around an array of
action[:type]s only to decide whether or not to show a request action tab, let the object itself tell about its tabs visibility instead.This PR refactors the way the request page tabs visibility is computed by moving the logic from an helper to a decorator class, based also on this discussion.