Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring tab visibility - use decorator instead of helper #14349

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Refactoring tab visibility - use decorator instead of helper #14349

merged 4 commits into from
Jun 30, 2023

Commits on Jun 30, 2023

  1. Use a decorator for determining tab visibility

    @ncounter
    ncounter committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    cdb9793 View commit details
    Browse the repository at this point in the history

  2. Use multiple functions instead of a switch statement

    @hellcp-work @ncounter
    hellcp-work authored and ncounter committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1cc0432 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @ncounter
    ncounter committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    519ae80 View commit details
    Browse the repository at this point in the history

  4. Make sure the action belongs to the request

    @ncounter
    ncounter committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7cf0344 View commit details
    Browse the repository at this point in the history