More factories #1511
Merged
More factories #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChrisBr
commented
Feb 5, 2016
ChrisBr
commented
- Enhance project factory
- Add Configuration factory
| @@ -0,0 +1,7 @@ | |||
| FactoryGirl.define do | |||
| factory :configuration do | |||
There was a problem hiding this comment.
Configuration factory isn't needed... We already excluded from the truncation of the tables, so we always have a Configuration in the RSpec tests
There was a problem hiding this comment.
Yeah, but it's a convenient factory to get easily the attributes for updating a configuration!
There was a problem hiding this comment.
Otherwise I need to manually setup the attributes in the test. But I don't have strong feelings here, if you don't want the factory I can remove it and do it manually in the test...
There was a problem hiding this comment.
Lets discuss it together with @hennevogel and @bgeuken
There was a problem hiding this comment.
I'm totally fine with having a factory for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.