Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantly display the 'You reported the X' message #15299

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Instantly display the 'You reported the X' message #15299

merged 1 commit into from
Dec 4, 2023

Commits on Dec 4, 2023

  1. Instantly display the 'You reported the X' message

    A page refresh isn't needed anymore for the message to appear.
    
    For comments, the implementation isn't really robust, but considering
    how the comments are rendered, this is what we can do without
    refactoring a lot of code. In the best scenario, rendering a comment
    would be as simple as rendering a single view component. It would then
    be unneccessary to fiddle much with JavaScript, re-rendering the comment
    view component would be the solution.
    
    As for projects and packages, it's not possible to re-render the
    side_links partials since they depend upon so many objects and we don't
    have those in webui/reports_controller.
    dmarcoux authored and krauselukas committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e30abe9 View commit details
    Browse the repository at this point in the history