Manually fix FactoryBot/FactoryAssociationWithStrategy RuboCop offenses

src/api/.rubocop_todo.yml

@@ -61,22 +61,18 @@ FactoryBot/ExcessiveCreateList:
   Exclude:
     - 'spec/controllers/webui/monitor_controller_spec.rb'
 
-# Offense count: 33
+
+# Offense count: 24
 # Configuration parameters: Include.
 # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
 FactoryBot/FactoryAssociationWithStrategy:
   Exclude:
-    - 'spec/factories/attrib_default_values.rb'
     - 'spec/factories/attribs.rb'
-    - 'spec/factories/azure_configuration.rb'
     - 'spec/factories/bs_request_actions.rb'
     - 'spec/factories/bs_requests.rb'
     - 'spec/factories/comments.rb'
     - 'spec/factories/download_repository_factory.rb'
-    - 'spec/factories/group_maintainers.rb'
     - 'spec/factories/groups.rb'
-    - 'spec/factories/groups_user.rb'
-    - 'spec/factories/history_elements.rb'
     - 'spec/factories/kiwi_package.rb'
     - 'spec/factories/packages.rb'
     - 'spec/factories/path_element.rb'
@@ -86,7 +82,6 @@ FactoryBot/FactoryAssociationWithStrategy:
     - 'spec/factories/status_reports.rb'
     - 'spec/factories/tokens.rb'
     - 'spec/factories/watched_items.rb'
-    - 'spec/factories/workflow_artifacts_per_step.rb'
     - 'spec/factories/workflow_runs.rb'
 
 # Offense count: 3302

src/api/spec/factories/attrib_default_values.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :attrib_default_value do
-    attrib_type { create(:attrib_type) }
+    attrib_type
     position { 1 }
     value { Faker::Lorem.word }
   end

src/api/spec/factories/azure_configuration.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :azure_configuration, class: 'Cloud::Azure::Configuration' do
-    user { create(:user) }
+    user
     application_id { nil }
     application_key { nil }
 

src/api/spec/factories/group_maintainers.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :group_maintainer do
-    user { create(:user) }
-    group { create(:group) }
+    user
+    group
   end
 end

src/api/spec/factories/groups_user.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :groups_user do
-    user { create(:user) }
-    group { create(:group) }
+    user
+    group
   end
 end

src/api/spec/factories/history_elements.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory 'history_element' do
-    user { create(:user) }
+    user
     comment { Faker::Lorem.paragraph }
 
     # Inheriting from HistoryElement::Review

src/api/spec/factories/workflow_artifacts_per_step.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :workflow_artifacts_per_step, aliases: [:workflow_artifacts_per_step_branch_package] do
-    workflow_run { create(:workflow_run) }
+    workflow_run
     step { 'Workflow::Step::BranchPackageStep' }
 
     transient do