New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass host to link_to_reportables helper #16060
Pass host to link_to_reportables helper #16060
Conversation
Review app will appear here: http://obs-reviewlab.opensuse.org/saraycp-fix_report_link_to_reported_element |
414dcce
to
76023ae
Compare
Rebased on master |
76023ae
to
e29a827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to use *_path
helper methods and this will be ok... The report paths are not anything special, they do not need the host.
This is also used in mailers, which is why full url is required in some cases |
Then we should not use this helper, it's leaking mailing-specific behavior into the reports view. |
This PR literally removes mailing specific behavior from this helper |
Well, not really, the mailer specific behavior is still there, we just adapt the mailer so we can use it on regular pages. Anyway, looks like this helper is going away soon, so I won't block this anymore. |
e29a827
to
2b194b9
Compare
Fixes #16059