[webui] show timestamps in package revisions #2469
Conversation
| @@ -21,7 +21,9 @@ | |||
| committed | |||
| <% end %> | |||
| <% end %> | |||
| <%= fuzzy_time(Time.at(commit['time'].to_i)) %> (revision <%= commit['rev'] %>) | |||
| <% time = Time.at(commit['time'].to_i) %> | |||
| <span title="<%= time.utc %>" class='commit-fuzzy-time'><%= fuzzy_time(time) %></span> | |||
There was a problem hiding this comment.
how about integrating this into the fuzzy_time helper instead?
There was a problem hiding this comment.
But fuzzy_time is called from different places, do we want to change this everywhere?
There was a problem hiding this comment.
Also, I don't like rendering UTC. And I think that the seconds are not necessary.
What about something like this:
time.strftime("%Y-%m-%d %H:%M")
There was a problem hiding this comment.
Changing it everywhere, where it makes sense, sounds like a good idea. So that we stay consistent.
|
Nice one |
| @@ -21,7 +21,9 @@ | |||
| committed | |||
| <% end %> | |||
| <% end %> | |||
| <%= fuzzy_time(Time.at(commit['time'].to_i)) %> (revision <%= commit['rev'] %>) | |||
| <% time = Time.at(commit['time'].to_i) %> | |||
| <span title="<%= time.utc %>" class='commit-fuzzy-time'><%= fuzzy_time(time) %></span> | |||
There was a problem hiding this comment.
Also, I don't like rendering UTC. And I think that the seconds are not necessary.
What about something like this:
time.strftime("%Y-%m-%d %H:%M")
|
As long as the world hasn't agreed on a single timezone, you have to specify which one was used on the server. That's actually the charme of solutions like jquery.timeago where the date is rendered by the browser. |
There was a problem hiding this comment.
As long as the world hasn't agreed on a single timezone, you have to specify which one was used on the server. That's actually the charme of solutions like jquery.timeago where the date is rendered by the browser.
I would prefer using jquery than rendering UTC
| human_time_ago = time_ago_in_words(time) + ' ago' | ||
|
|
||
| if with_fulltime | ||
| raw("<span title='#{time.utc}' class='fuzzy-time'>#{human_time_ago}</span>") |
There was a problem hiding this comment.
I would prefer not to render seconds.
|
Using jquery.timeago would only make sense if all times are displayed in the local client timezone. They are not, so this would be very confusing I guess. |
DavidKang
force-pushed
the
show_timestamps_on_package_revisions
branch
from
157fae0
to
34d4d50
Compare
|
@Ana06, when you can, please check if the changes. |
| it { expect(fuzzy_time(Time.now)).to eq('now') } | ||
| end | ||
|
|
||
| context 'with_fulltime' do |
There was a problem hiding this comment.
What is this testing? :-) strftime?
Related with issue #2164
Before:
After:
