[ci] Use nested module syntax for Kiwi classes #4010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisBr, please rebase to resolve the conflicts. |
to make codecov hopefully working for Kiwi files."
ChrisBr
force-pushed
the
bugfix/kiwi_codecov
branch
from
262dcd3
to
43fdd3e
Compare
|
@DavidKang done! |
DavidKang
approved these changes
Oct 13, 2017
bgeuken
reviewed
Oct 13, 2017
| <type image="oem" primary="true" boot="oemboot/suse-13.2"/> | ||
| </preferences> | ||
| </image> | ||
| '.freeze |
There was a problem hiding this comment.
@ChrisBr The whole xml snippet is a string and shouldn't be indented. Otherwise the formatting of the xml is wrong and breaks our tests.
I did the same mistake when trying to use a modularize this;-)
There was a problem hiding this comment.
So means you already tried this and it didn't work?
|
superseeded in #4080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make codecov work again.