[frontend] Use nested module syntax for Kiwi classes #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplecov has problems to calculate coverage otherwise...
|
I guess it's easier to review if you look at the diff without whitespace |
mdeniz
approved these changes
Oct 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
+ Coverage 88.35% 88.35% +<.01%
==========================================
Files 313 313
Lines 18303 18307 +4
==========================================
+ Hits 16171 16175 +4
Misses 2132 2132
|
|
The coverage report still does not include the |
|
Now the only difference is that |
|
Don't know what to do with this now. Close it? |
Its up to you what to with this PR! I've been using nested syntax just because I'm already in the habit of using it, maybe we should agree on which on to use? |
|
Let's merge it... at least is more consistent, isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecov has problems to calculate coverage otherwise...