Ruby 2.5 for 2.9 branch #4464
Merged
Ruby 2.5 for 2.9 branch #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to get rid of deprecation warnings. This needs to get updated manually as it is an indirect dependency depfu currently does not pick up.
bgeuken
approved these changes
Feb 8, 2018
|
you might want to add #4460 as well. It's only a docker change. So not necessarily needed for OBS 2.9. But maybe for the sake of completeness^^ |
bgeuken
added
Frontend
adrianschroeter
added
the
DO NOT MERGE ⚠️
|
I like to wait for a few more days running in production on ruby2.5 before really doing the merge into 2.9 branch .... |
Since we are not using the ruby version defined by the base system, but the one OBS uses, we have to adjust the call of the binaries that were installed via gem command.
Codecov Report
@@ Coverage Diff @@
## 2.9 #4464 +/- ##
=========================================
- Coverage 88.11% 88.1% -0.02%
=========================================
Files 352 352
Lines 18709 18711 +2
=========================================
- Hits 16486 16485 -1
- Misses 2223 2226 +3
|
|
I think we have waited enough. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cherry-picked from master....