Refactor build controller #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgeuken
force-pushed
the
refactor_build_controller
branch
from
bf4107c
to
e96188e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4475 +/- ##
==========================================
+ Coverage 88.43% 88.44% +0.01%
==========================================
Files 352 352
Lines 18690 18683 -7
==========================================
- Hits 16528 16525 -3
+ Misses 2162 2158 -4
|
Use Array#map instead of using a temporary variable to collect arch results.
bgeuken
force-pushed
the
refactor_build_controller
branch
from
e96188e
to
892f695
Compare
hennevogel
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.