Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] bs_admin: add option to replace a project's signing key #4910

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

bluca
Copy link
Contributor

@bluca bluca commented Apr 25, 2018

It is sometimes useful to be able to sign with existing keys, perhaps
due to corporate policies (EG: for EFI Secure Boot).
It is not enough to substitute a project's _signkey and _pubkey on the
filesystem, the database has to be updated or the previous _sslcert
will be used, since that is never stored on the disk.
Add a new --update-project-signing-key option to bs_admin to facilitate
the operation for an administrator.

@bluca bluca force-pushed the bs_admin_replace_signing_key branch 2 times, most recently from 241869f to 65d0053 Compare April 26, 2018 22:26
@bgeuken bgeuken added the Backend Things regarding the OBS backend label Apr 27, 2018
@adrianschroeter
Copy link
Member

the sslcert should become optional.

And you are aware that it needs to match the gpg key? Maybe this should be added to the help.

@adrianschroeter
Copy link
Member

please add that the key must have no passphrase.

(mls would even prefer when the encryption would be done by bs_admin instead of having it in the help, but I would also merge it this way :)

@bluca bluca force-pushed the bs_admin_replace_signing_key branch 2 times, most recently from 61a136d to 22af60e Compare May 3, 2018 12:44
@bluca
Copy link
Contributor Author

bluca commented May 3, 2018

@adrianschroeter thanks for the review!

the sslcert should become optional.

Ok, done. Not passing it means it will be removed if present - otherwise it won't match anymore.

And you are aware that it needs to match the gpg key? Maybe this should be added to the help.

Yes - done, better to specify it, I agree.

please add that the key must have no passphrase.

Good point, done.

(mls would even prefer when the encryption would be done by bs_admin instead of having it in the help, but I would also merge it this way :)

It could, but then one would have to copy the private key in plain text on the backend server, where multiple admins might have access, right? This way instead it can be encrypted off box by whoever is responsible (yes it can be decrypted after the fact by the admins of the signer machine, but that's supposed to be separate and restricted).

I can try and make that optional if you feel like it would be useful.

@coolo
Copy link
Member

coolo commented Jul 12, 2018

@adrianschroeter ?

It is sometimes useful to be able to sign with existing keys, perhaps
due to corporate policies (EG: for EFI Secure Boot).
It is not enough to substitute a project's _signkey and _pubkey on the
filesystem, the database has to be updated or the previous _sslcert
will be used, since that is never stored on the disk.
Add a new --update-project-signing-key option to bs_admin to facilitate
the operation for an administrator.
@bluca bluca force-pushed the bs_admin_replace_signing_key branch from 22af60e to 10b8486 Compare October 17, 2018 18:48
@Ana06
Copy link
Member

Ana06 commented Jan 7, 2019

@adrianschroeter what is the state of htis? 😕

@bluca
Copy link
Contributor Author

bluca commented Jan 7, 2019

@adrianschroeter what is the state of htis?

A bit stuck :-) Please let me know if there's anything else I can do to help get this merged. Thanks!

@adrianschroeter adrianschroeter merged commit de6bce5 into openSUSE:master Jan 17, 2019
@bluca bluca deleted the bs_admin_replace_signing_key branch January 17, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Things regarding the OBS backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants