Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the method discard_cache? as it never worked as intended. #5849

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

vpereira
Copy link
Contributor

The key HTTP_CACHE_CONTROL doesn't live on request.headers but request.env, as you can see here https://api.rubyonrails.org/v5.2.0/classes/ActionDispatch/Request.html

@vpereira
Copy link
Contributor Author

@coolo as we spoke earlier

@coolo
Copy link
Member

coolo commented Sep 13, 2018

Now seriously: if this is broken since 5fede5b (2012), we most likely don't need this function :)

It's purpose was to have a reliable F5, but looks like noone cares. So just give it a shove and just never discard caches.

@vpereira
Copy link
Contributor Author

Now seriously: if this is broken since 5fede5b (2012), we most likely don't need this function :)

It's purpose was to have a reliable F5, but looks like noone cares. So just give it a shove and just never discard caches.

Yup. Much better

@vpereira vpereira changed the title fix check for HTTP_CACHE_CONTROL in the request environment remove the method discard_cache? as it was never worked as intended. Sep 13, 2018
@mdeniz mdeniz added the Frontend Things related to the OBS RoR app label Sep 13, 2018
This method never really worked and the idea behind was to
allow the client to invalidate the server cache remotely
@dmarcoux dmarcoux changed the title remove the method discard_cache? as it was never worked as intended. Remove the method discard_cache? as it never worked as intended. Sep 13, 2018
@vpereira vpereira merged commit ef27aaa into openSUSE:master Sep 13, 2018
@vpereira vpereira deleted the http_cache_control branch October 18, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants