Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of fields for small devices #6053

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

eduardoj
Copy link
Member

@eduardoj eduardoj commented Oct 8, 2018

... on package show page, using CSS Grid Layouts.

Fixes partially #5976, only the order, not limiting the size.

@eduardoj eduardoj added Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started Bootstrap 🚀 Bootstrap migration labels Oct 8, 2018
@obs-bot
Copy link
Collaborator

obs-bot commented Oct 8, 2018

Review app will appear here: http://obs-reviewlab.opensuse.org/eduardoj-change_order_of_fields

Copy link
Member

@hennevogel hennevogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks responsiveness...

@hennevogel
Copy link
Member

screenshot from 2018-10-08 16-59-15

... on package show page using CSS Grid Layouts.

Fixes partially openSUSE#5976, only the order, not limiting the size.
@eduardoj
Copy link
Member Author

eduardoj commented Oct 9, 2018

@hennevogel:

This breaks responsiveness...

Fixed. Now it should work.

@hennevogel hennevogel merged commit cfb9891 into openSUSE:master Oct 9, 2018
@eduardoj eduardoj deleted the change_order_of_fields branch October 9, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants