Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository state view #6462

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

ChrisBr
Copy link
Member

@ChrisBr ChrisBr commented Dec 4, 2018

Safe join does not work on a string / array, see documentation:

https://apidock.com/rails/ActionView/Helpers/OutputSafetyHelper/safe_join

Fix #6459

@bgeuken bgeuken added the Frontend Things related to the OBS RoR app label Dec 4, 2018
Copy link
Member

@bgeuken bgeuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

btw you were referencing to the Rails 4 docu:wink: But it's still the same

@ChrisBr ChrisBr merged commit 27f8290 into openSUSE:master Dec 4, 2018
@ChrisBr ChrisBr deleted the fix_repo_state branch December 11, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants