Fix link for downloading a binary

[bmwiedemann]

Without this patch,
https://build.opensuse.org/package/binary/home:bmwiedemann/git-deps/openSUSE_Leap_15.0/x86_64/git-deps-1-lp150.5.1.noarch.rpm
had

<h3>
Detailed Information About git-deps-1-lp150.5.1.noarch.rpm
<a title="Download file" href="<a href=&quot;https://api.opensuse.org:443/build/home:bmwiedemann/openSUSE_Leap_15.0/x86_64/git-deps/git-deps-1-lp150.5.1.noarch.rpm&quot;>git-deps-1-lp150.5.1.noarch.rpm</a>"><i class='fas fa-download text-secondary'></i>
</a></h3>

[vpereira]

nice catch @bmwiedemann !

[bmwiedemann]

btw: I did not actually test the new version

[Ana06]

thanks @bmwiedemann 💐

[dmarcoux]

This produces an error:

[bmwiedemann]

@dmarcoux https://github.com/openSUSE/open-build-service/blob/master/src/api/app/helpers/webui/webui_helper.rb#L275 has similar syntax, except for the do - what is that intended to do?

[dmarcoux]

The block (so everything under the do) is the content of the link, so what is displayed to the user. When there is a block, link_to's first parameter is the URL of the link. When there isn't a block, the first parameter is the content of the link (for details)

In this case, we don't need the filename. I will push the changes. We already have the download icon and the title, so it's pretty clear with what we use throughout the Bootstrap/new UI.

[dmarcoux]

@vpereira @Ana06 Please review again and feel free to dismiss my review once this is done (as it was prior to the changes I pushed)

[codecov]

Codecov Report

Merging #6732 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6732      +/-   ##
==========================================
+ Coverage   90.68%   90.68%   +<.01%     
==========================================
  Files         473      473              
  Lines       20474    20477       +3     
==========================================
+ Hits        18566    18569       +3     
  Misses       1908     1908

[Ana06]

ouch! 🙈

he push changes already :)