Fix JavaScript syntax error #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is `SyntaxError: missing ) after argument list`. It's not so obvious at first, but we need to pass the options as an object.
dmarcoux
added
Frontend
eduardoj
approved these changes
Jun 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #7686 +/- ##
==========================================
- Coverage 90.75% 90.72% -0.03%
==========================================
Files 499 499
Lines 21378 21378
==========================================
- Hits 19401 19395 -6
- Misses 1977 1983 +6 |
DavidKang
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is
SyntaxError: missing ) after argument list. It's not so obvious at first, but we need to pass the options as an object.