-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure language exists #8168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8168 +/- ##
==========================================
+ Coverage 90.79% 90.81% +0.01%
==========================================
Files 502 502
Lines 21445 21447 +2
==========================================
+ Hits 19471 19477 +6
+ Misses 1974 1970 -4 |
Codecov Report
@@ Coverage Diff @@
## master #8168 +/- ##
==========================================
- Coverage 90.82% 90.81% -0.01%
==========================================
Files 502 502
Lines 21445 21447 +2
==========================================
Hits 19477 19477
- Misses 1968 1970 +2 |
hennevogel
requested changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's time to add a spec for this...
eduardoj
requested changes
Aug 23, 2019
eduardoj
approved these changes
Aug 26, 2019
vpereira
approved these changes
Aug 26, 2019
hennevogel
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8167
Skips over coderay entirely if no language is input, to save on having additional processing for that, and additional classes coderay would insert for text.