Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure language exists #8168

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Make sure language exists #8168

merged 2 commits into from
Aug 26, 2019

Conversation

hellcp
Copy link
Member

@hellcp hellcp commented Aug 23, 2019

Fixes #8167

Skips over coderay entirely if no language is input, to save on having additional processing for that, and additional classes coderay would insert for text.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #8168 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8168      +/-   ##
==========================================
+ Coverage   90.79%   90.81%   +0.01%     
==========================================
  Files         502      502              
  Lines       21445    21447       +2     
==========================================
+ Hits        19471    19477       +6     
+ Misses       1974     1970       -4

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #8168 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8168      +/-   ##
==========================================
- Coverage   90.82%   90.81%   -0.01%     
==========================================
  Files         502      502              
  Lines       21445    21447       +2     
==========================================
  Hits        19477    19477              
- Misses       1968     1970       +2

@hennevogel hennevogel added the Frontend Things related to the OBS RoR app label Aug 23, 2019
Copy link
Member

@hennevogel hennevogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's time to add a spec for this...

src/api/lib/obsapi/markdown_renderer.rb Outdated Show resolved Hide resolved
@hennevogel hennevogel merged commit 3a6f08c into openSUSE:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[production][package#show] Symbol or String expected, but NilClass given.
4 participants