-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] adding appstream.xml and appstream-icons to match appstream-generator requirements #9019
base: master
Are you sure you want to change the base?
Conversation
You are aware that the publisher is not creating the factory repository of the products? It is also potential incompatible, but maybe okay. Are we sure that old code streams and tooling is not stumbling over the new file? We may need a configuration option otherwise ... Please prefix your commit with [backend] tag. thanks! |
Does it make to have both files at the same time at all? Otherwise I would go with a config option instead... |
…-generator requirements
…ld-service into appstream-rename
|
Yes, it already does a copy of appdata to appease both SLE12 and SLE15. What transpired from issue #8999 is that the filenames are different for the latest appstream specification.
|
Codecov Report
@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
- Coverage 90.98% 90.98% -0.01%
==========================================
Files 513 513
Lines 21118 21118
==========================================
- Hits 19215 19214 -1
- Misses 1903 1904 +1 |
What "latest appstream specification"? Such a thing does not really exist for the repository metadata. |
Fixing publisher code to also generate the appstream.xml and appstream-icons.gz files, to match what appstream-generator and everything that uses appdata look for (like Gnome Software) in recent releases.
We're also changing the way Leap 15.2 and Tumbleweed look for appdata to match this, as proposed in DimStar77/openSUSE-appstream#2
As discussed in #8999 .