Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_checker: provide whitelist_clean subcommand. #1505

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

jberry-suse
Copy link
Contributor

  • 35989be:
    repo_checker: provide whitelist_clean subcommand.

    Removes whitelist entries that are no longer mentioned in repo_checker
    output and condenses entries common to all.

  • c4f799d:
    osclib/core: correct BINARY_REGEX by making it greedy.

    Should not effect RPM_REGEX usage since it appends suffix.

Automates the last portion of poo#35425.

I ran locally for Leap 15.0:

$ ./repo_checker.py whitelist_clean openSUSE:Leap:15.0
--- config.orig
+++ config.new
@@ -15,9 +15,9 @@
 repo_checker-arch-whitelist = x86_64
 
 # these issues should be resolved, see dashboard/repo_checker for details
-repo_checker-binary-whitelist = atkmm1_6-doc autoyast2 build-mkbaselibs build-mkbaselibs-sle devscripts duplicity dvd+rw-tools gedit-plugin-zeitgeist git-cvs gnome-boxes gnome-boxes-lang gnome-builder-plugin-ctags gnome-builder-plugin-gnome-code-assistance gnome-builder-plugin-jedi gnome-shell-search-provider-boxes graphviz graphviz-smyrna gtkmm3-doc inkscape-extensions-skencil java-1_7_0-openjdk-accessibility java-1_8_0-openjdk-accessibility k3b k3b-devel k3b-lang kdebase4-workspace kiwi-instsource-plugins-openSUSE-13-2 ldirectord libreoffice-l10n-fi libvirt-daemon-vbox monitoring-plugins-metadata ocaml-brlapi patterns-media-rest_cd_core patterns-media-rest_cd_gnome patterns-media-rest_cd_kde patterns-media-rest_cd_x11 pcp-import-iostat2pcp pcp-import-sar2pcp pcp-pmda-ds389 pcp-pmda-ds389log pcp-pmda-snmp perl-CPAN-Meta plasma-nm5-openvpn plasma-nm5-strongswan python-katedj python-kdebase4 python2-Beaker python2-kiwi python3-Beaker samba-pidl sk1 skelcd-control-openSUSE speech-dispatcher-configure unbound-munin xorg-x11-Xvnc-novnc  firewall-applet kernel-default-livepatch NetworkManager-vpnc NetworkManager-vpnc-gnome NetworkManager-vpnc-lang plasma-nm5-vpnc patterns-media-rest_dvd
+repo_checker-binary-whitelist = patterns-media-rest_dvd kiwi-instsource-plugins-openSUSE-13-2
 
-repo_checker-binary-whitelist-x86_64 = ceph ceph-mgr enchant-voikko-32bit idnkit-devel-32bit libfabric-devel-32bit libvoikko1-32bit patterns-devel-base-devel_web patterns-media-rest_dvd perl-CPAN-Meta python-katedj python3-Beaker samba-pidl skelcd-control-openSUSE zeitgeist
+repo_checker-binary-whitelist-x86_64 =
 
 nocleanup-packages = bootstrap-copy 000product 000release-packages
 

Apply config changes? [y/n] (y):

Created revision 879.

@jberry-suse
Copy link
Contributor Author

@coolo may want to run on SLE-15 as the whitelists are rather large.

@jberry-suse
Copy link
Contributor Author

It suggests zero changes to Factory, a testament to the maintainer there. :) If this approach is agreeable I could add it to the project_only run of repo_checker to automatically cleanup entries once resolved. Presumably anything else should be handled with staging specific config (ie osc staging config).

Should not effect RPM_REGEX usage since it appends suffix.
Removes whitelist entries that are no longer mentioned in repo_checker
output and condenses entries common to all.
@jberry-suse jberry-suse merged commit adab26c into openSUSE:master Apr 26, 2018
@jberry-suse jberry-suse deleted the repo_checker-whitelist-clean branch April 26, 2018 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant