-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkglistgen: cli: Explicitly enable product-composer instead of detecting directories. #3091
pkglistgen: cli: Explicitly enable product-composer instead of detecting directories. #3091
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3091 +/- ##
==========================================
- Coverage 28.01% 27.98% -0.03%
==========================================
Files 86 87 +1
Lines 14987 15003 +16
==========================================
Hits 4199 4199
- Misses 10788 10804 +16 ☔ View full report in Codecov by Sentry. |
Why? |
pkglistgen as it is on master is broken on product-composer based products (SL Micro 6.0 and 6.1 currently). Running
yields
This is because This PR is not final and just an attempt at having correctly generated pkglists on SL Micro 6.1 . If it works we can work on a more structured proposal. What do you think? |
Sure. For now just this particular failure should be guarded IMO |
e7daea5
to
adfba88
Compare
I've tested this in one of the SLE 15 SP6 stagings, old behaviour ("legacy engine") works as expected. |
I know I said I'd work on a more structured proposal but we need this running on SLFO stagings ASAP. In a perfect universe we should really get rid of all What do you think? |
If you need a quick fix for quick deployment, I'd prefer a as small as possible fix to address only the immediate exception. Bigger changes like this need a more in-depth review... |
245e1c6
to
33c0b44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, with some nitpicks.
I want to highlight though the write_all_groups()
method not being called anymore in product-compose mode. Which is fine to me, but it's currently different with what is in master
right now.
Either way, tested against a SLE15SP6 staging (in "legacy" mode) and the output has been what I expected. Thanks!
bc47adc
to
3680551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! 💯
Aside from the one-line change in my latest comment (self.product_dir
-> product_dir
), it works as expected against a SLE15SP6 staging.
I will schedule a full target build so we can check that as well.
3680551
to
c831ba0
Compare
@Vogtinator Could you please give an in depth review to this PR? It was tested on SL Micro 6.1, SLFO Stagings and SLCS 6.0 and it is currently running for SLE 15 SP6 's target. Thank you |
Can do, but earliest tomorrow |
Tested on SLE15SP6 target (sorry, it took a rather long time), and the output is as expected. |
@Vogtinator were you able to take a look at this PR? Thank you |
030339d
to
b883f63
Compare
b883f63
to
6d3b8a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SP6 Staging and Targets work fine, my remarks were addressed, flake8 is happy: looks good to me
This PR is based on #3089