Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Style/RedundantReturn offenses #1824

Closed
Ana06 opened this issue Nov 29, 2017 · 2 comments
Closed

Fix Style/RedundantReturn offenses #1824

Ana06 opened this issue Nov 29, 2017 · 2 comments
Labels
good first issue For RoR beginners or people unfamiliar with the application

Comments

@Ana06
Copy link
Member

Ana06 commented Nov 29, 2017

Fix Style/RedundantReturn Rubocop cop offenses and remove the exclusion from the todo file. :bowtie:

This cop checks for redundant return expressions. It support autocorrection.

https://rubocop.readthedocs.io/en/latest/cops_style/#styleredundantreturn
@Ana06 Ana06 added good first issue For RoR beginners or people unfamiliar with the application Junior labels Nov 29, 2017
@SidharthBansal
Copy link
Contributor

May I take this issue and make a pull request?

@Ana06
Copy link
Member Author

Ana06 commented Dec 3, 2017

@SidharthBansal go ahead! 👍

@SidharthBansal SidharthBansal mentioned this issue Dec 4, 2017
Merged
SidharthBansal added a commit to SidharthBansal/osem that referenced this issue Dec 4, 2017
@SidharthBansal
Fix Style/ReductantReturn rubocop
020dae3 
Exclusions from .rubocop_todo.yml deleted.This cop checks for redundant return expressions.
Fixes openSUSE#1824
chocoelho pushed a commit to chocoelho/osem that referenced this issue Feb 18, 2018
@SidharthBansal @chocoelho
Fix Style/ReductantReturn rubocop
67d9b4a 
Exclusions from .rubocop_todo.yml deleted.This cop checks for redundant return expressions.
Fixes openSUSE#1824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For RoR beginners or people unfamiliar with the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ana06 @SidharthBansal