Fix Style/ReductantReturn rubocop #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ana06
requested changes
Dec 4, 2017
There was a problem hiding this comment.
The code look great 😍 But the commit message has the same problems as in your other PR. Please read our commit guidelines. 😉
|
I am really sorry for not writing the commit message. I have read the contribution guidelines. Will follow it definitely from next time. |
And please modify it in this PR as well. Do you know how to do it? If not ask and I'll help you 😉 |
Exclusions from .rubocop_todo.yml deleted.This cop checks for redundant return expressions. Fixes openSUSE#1824
|
@Ana06 |
Ana06
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Style/ReductantReturn rubocop offenses and deleted exclusions from .rubocop_todo.yml
This cop checks for redundant return expressions. It supports autocorrection.
Fixed #1824.