Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore colors parameter of donut chart partial #2971

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

Some donut charts are all black:

  • Administration → Events
  • Administration → Users
  • Manage conference → Events → Events state

Changes proposed in this pull request

Pass the colors parameter of the donut chart partial to Chartkick.

This parameter was accidentally disconnected in commit c967a0b
but is still used by `app/views/admin/conferences/index.html.haml` and
`app/views/admin/events/index.html.haml`.
@hennevogel hennevogel merged commit c3dfd76 into openSUSE:master Mar 29, 2022
@AndrewKvalheim AndrewKvalheim deleted the chart-colors branch March 30, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants