Corrections to proposal help text #3243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers: - initial form of new proposal - changed form of new proposal - initial form of existing proposal - changed form of existing proposal
Accidentally lost during 81853d1 Resolves: 1) Event as a participant not signed_in user submits proposal Failure/Error: expect(page).to have_text 'Abstracts must be between 0 and 500 words.' expected to find text "Abstracts must be between 0 and 500 words." in "…Abstracts must be between 0 and 250 words.…" # ./spec/features/proposals_spec.rb:94 250 is the initial value hard-coded in app/views/proposals/_form.html.haml
Prior to this the view literally contained:
You have used = @event.abstract_word_count words.
Incidentally resolves a JavaScript error introduced in openSUSE#3138 affecting pages without the proposal form: Uncaught TypeError: text is undefined at word_count (app/assets/javascripts/osem.js:134)
AndrewKvalheim
force-pushed
the
proposal-help-text
branch
from
68394d6
to
99c854f
Compare
|
How do I run this locally? What JSHint configuration is it using? |
I don't think Codacy supports this.
The one setup in the tool. If you login there you can enabled/disabled hints. We can also carry a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves
Three interconnected issues related to help text on the proposal form:
The proposal form ignores the length requirements of event types. It always displays a hard-coded value:
The static proposal form contains unevaluated view code:
#3138 introduced a JavaScript error on pages that don’t contain the proposal form:
Changes proposed in this pull request
Restore the length requirement data accidentally lost in Rails7 #2914.
Correct the malformed Haml.
The purpose of the code that triggers the error is to immediately overwrite server-rendered content on the client. Ideally the server should just render the correct content in the first place. So do that, and remove the now unnecessary client side render.