Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display track description on event proposal form #3138

Merged
merged 3 commits into from Apr 19, 2023

Conversation

AndrewKvalheim
Copy link
Member

@AndrewKvalheim AndrewKvalheim commented Mar 10, 2023

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

  1. The help text for the difficulty level field doesn’t appear until the value has been changed. (The event type field is also affected, but this is mitigated by an incidental synthetic change event.)

  2. CfP respondents don’t have a way to see the descriptions of available tracks.

Changes proposed in this pull request

  1. Render help text with the correct initial visibility.

  2. Show the track description as help text:

    screenshot

@AndrewKvalheim AndrewKvalheim changed the title Display track description on proposal form Display track description on event proposal form Mar 10, 2023
@AndrewKvalheim AndrewKvalheim marked this pull request as draft March 10, 2023 23:13
@AndrewKvalheim AndrewKvalheim marked this pull request as ready for review March 10, 2023 23:39
Incidentally fulfills the same need as openSUSE#2662
@AndrewKvalheim AndrewKvalheim force-pushed the track-help branch 2 times, most recently from ed31784 to 98ea1bf Compare March 11, 2023 21:33
Resolves failure to display initial help text of difficulty level.
Tracks are otherwise undocumented for CfP respondents.
@hennevogel hennevogel merged commit af44d58 into openSUSE:master Apr 19, 2023
@AndrewKvalheim AndrewKvalheim deleted the track-help branch May 4, 2023 17:42
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2023
Incidentally resolves a JavaScript error introduced in openSUSE#3138 affecting
pages without the proposal form:

    Uncaught TypeError: text is undefined
      at word_count (app/assets/javascripts/osem.js:134)
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2023
Incidentally resolves a JavaScript error introduced in openSUSE#3138 affecting
pages without the proposal form:

    Uncaught TypeError: text is undefined
      at word_count (app/assets/javascripts/osem.js:134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants