Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dashboard helper methods #162

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

okurz
Copy link
Member

@okurz okurz commented Feb 1, 2024

This commit extracts requests get/put/patch calls to its own module so
that the common URL construction using the dashboard URL is not repeated
over and over again.

This commit extracts requests get/put/patch calls to its own module so
that the common URL construction using the dashboard URL is not repeated
over and over again.
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5d4cf4a) 66.82% compared to head (ca90612) 66.96%.

Files Patch % Lines
openqabot/loader/qem.py 26.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   66.82%   66.96%   +0.14%     
==========================================
  Files          24       25       +1     
  Lines        1658     1662       +4     
==========================================
+ Hits         1108     1113       +5     
+ Misses        550      549       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Little steps towards more maintainable code

@mergify mergify bot merged commit dd69131 into openSUSE:master Feb 1, 2024
3 checks passed
@okurz okurz deleted the feature/dashboard_requests branch February 2, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants