-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a filter for job groups in blocked page #303
Conversation
- Allow to filter for multiple job groups, separated by ','
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From kraih's review suggestions:
- more modern JavaScript style
- existing filter field reused if possible
- some basic tests at least (same as other filters)
- Find a better way than
var results = []
Regarding tests, unfortunately we only have the bare minimum for filtering so far. You can watch the test run locally with something like |
a1dc584
to
2f04b84
Compare
2f04b84
to
0193bb5
Compare
All changes requested should be done and squashed in a commit. Now will try to add some tests |
Is it still a separate search field below the other search field? |
@kraih
|
Wonder if it would look cleaner if the search fields were each above their respective table column, instead of above one another. 🤔 |
Co-authored-by: Martchus <martchus@gmx.net>
Follow-up to continue discussion from #302