Fix salt-sproxy crashing because of mislead requirements in installed Salt #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Salt has a
msgpack<1.0.0
line in requirements/base.txt even if as a package runs withmsgpack>=1.0.0
requirement in the installed metadata. If a program uses the metadata to evaluate requirements, like salt-sproxy does, it will crash.What issues does this PR fix or reference?
I am preparing salt-sproxy (https://build.opensuse.org/package/show/home:dmacvicar/salt-sproxy) and found this problem.
Note that salt-sproxy also restricts msgpack, and we apply a similar fix.
See: https://twitter.com/mirceaulinic/status/1287871911255347200
Previous Behavior
New Behavior
Tests written?
No
Commits signed with GPG?
No