Update docker environment to Leap 15 + ruby2.5 #369
Conversation
| # Setup bundler | ||
| RUN bundle config build.nokogiri --use-system-libraries | ||
|
|
||
| CMD ["bundle", "exec", "rails", "server"] |
There was a problem hiding this comment.
Is this needed, to remove this CMD line? If so I would comment it in the commit message.
There was a problem hiding this comment.
The problem is that the first vagrant up can't start it because the gems are not installed. I've tried moving bundle install in the Dockerfile, but that did not really work well.
On consecutive vagrant ups the provisioning is skipped and bundle exec rails server is not executed. Maybe the better alternative is to enable ssh which should allow vagrant to provision again and automatically start rails (right now the developer has to docker attach software_web and bundle exec rails server every time which is not really nice.
There was a problem hiding this comment.
I would try using docker-compose instead docker from vagrant. But I'm not going to stop this from being merged. So fine for me.
| @@ -134,37 +134,37 @@ Windows. | |||
|
|
|||
| 1. Install [Vagrant](https://www.vagrantup.com/downloads.html) and [docker](https://docs.docker.com/engine/getstarted/step_one/). Both tools support Linux, MacOS and Windows. | |||
|
|
|||
| 2. Clone this code repository: | |||
| 1. Clone this code repository: | |||
There was a problem hiding this comment.
Why do you change the numbers? The plain markdown file is less readable this way.
Markdown aims to have a readable plain text file as long as a prettified rendered document. ;)
There was a problem hiding this comment.
You are right, it is a bit less readable. Using "1." for every number makes it easier to change the list. If you want to insert/remove a step in the middle, you don't have to renumber everything below (technically you don't have to do it even when using a higher number, but then it gets confusing).
Using "1." makes it clear that this is a ordered list, if you want to edit it that is enough (you just care about the order itself, not which number a step has).
For just viewing, I recommend the rendered version if you care about its beauty. Reading the plain version of this is still good enough as a step by step checklist in my opinion (here we have the commands that take up 3 lines and make good "anchors").
Use latest leap for docker and update documentation. Installing `rbtrace` in the docker environment does not succeed and is disabled in the Gemfile. Docker CMD line is removed since gems are not installed automatically, so the first `vagrant up` does not start rails and no further provisioning is possible without SSH.
agraul
changed the title
Use latest leap for docker and update documentation.
Installing
rbtracein the docker environment does not succeed and is disabled in the Gemfile. I suspect not many actually use it and those who really want it can easily re-enable it.Fixes #238