Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update puma: 4.3.3 → 4.3.5 (patch) #802

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 22, 2020


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ puma (4.3.3 → 4.3.5) · Repo · Changelog

Security Advisories 🚨

🚨 HTTP Smuggling via Transfer-Encoding Header in Puma

Impact

By using an invalid transfer-encoding header, an attacker could
smuggle an HTTP response.

Patches

The problem has been fixed in Puma 3.12.5 and Puma 4.3.4.

🚨 HTTP Smuggling via Transfer-Encoding Header in Puma

Impact

This is a similar but different vulnerability to the one patched in 3.12.5 and 4.3.4.

A client could smuggle a request through a proxy, causing the proxy to send a response
back to another unknown client.

If the proxy uses persistent connections and the client adds another request in via HTTP
pipelining, the proxy may mistake it as the first request's body. Puma, however,
would see it as two requests, and when processing the second request, send back
a response that the proxy does not expect. If the proxy has reused the persistent
connection to Puma to send another request for a different client, the second response
from the first client will be sent to the second client.

Patches

The problem has been fixed in Puma 3.12.6 and Puma 4.3.5.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 22, 2020
@depfu depfu bot force-pushed the depfu/update/puma-4.3.5 branch from 7f348fd to 03988ab Compare June 19, 2020 11:51
@depfu depfu bot changed the title 🚨 [security] Update puma: 4.3.3 → 4.3.5 (patch) 🚨 [security] Update puma: 4.3.3 → 4.3.5 (patch) Jun 19, 2020
@depfu depfu bot force-pushed the depfu/update/puma-4.3.5 branch from 03988ab to 6406e5f Compare June 19, 2020 12:15
@lkocman
Copy link
Contributor

lkocman commented Jun 19, 2020

Failed on ruby 2.7. See Issue #815

@lkocman lkocman merged commit 9ec3617 into master Jun 19, 2020
@depfu depfu bot deleted the depfu/update/puma-4.3.5 branch June 19, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant