Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test errors on ruby-2.7 (production is ruby 2.5) #815

Closed
lkocman opened this issue Jun 19, 2020 · 2 comments · Fixed by #883
Closed

Fix test errors on ruby-2.7 (production is ruby 2.5) #815

lkocman opened this issue Jun 19, 2020 · 2 comments · Fixed by #883
Assignees
@agraul
Labels
depfu

Comments

@lkocman
Copy link
Contributor

lkocman commented Jun 19, 2020 •
edited
Loading

All ruby 2.5 tests are currently passing, however 2.7 not. We need to address these. It's not a priority since production runs on ruby 2.5
@lkocman lkocman added the depfu label Jun 19, 2020
This was referenced Jun 19, 2020
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
@lkocman
Copy link
Contributor Author

lkocman commented Jun 19, 2020

ruby_2.7_log.txt

This was referenced Jun 23, 2020
Merged
Merged
This was referenced Jun 30, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@agraul agraul mentioned this issue Aug 4, 2020
Merged
@agraul
Copy link
Member

agraul commented Aug 4, 2020

CI is able to run test for 2.7 again, the build does not error anymore. There are test failings that need to be investigated, but at least they are exposed now.

@agraul agraul self-assigned this Aug 4, 2020
@agraul agraul mentioned this issue Aug 10, 2020
Merged
This was referenced Oct 22, 2020
Merged
Merged
@doenietzomoeilijk doenietzomoeilijk mentioned this issue Oct 23, 2020
Merged
1 task
agraul added a commit to agraul/software-o-o that referenced this issue Oct 26, 2020
@agraul
Don't try to Time.parse a "Time" object
18c3248 
With Ruby2.7, Time can't be converted into a String implicitly. The way
we use Time.parse, we don't need to convert the Time object into a
String just to convert it into a Time object again (using Time.parse).

Fixes openSUSE#815.
@agraul agraul mentioned this issue Oct 26, 2020
Merged
1 task
agraul added a commit to agraul/software-o-o that referenced this issue Oct 30, 2020
@agraul
Don't try to Time.parse a "Time" object
7c2dfd8 
With Ruby2.7, Time can't be converted into a String implicitly. The way
we use Time.parse, we don't need to convert the Time object into a
String just to convert it into a Time object again (using Time.parse).

Fixes openSUSE#815.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agraul agraul

Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't try to Time.parse a "Time" object agraul/software-o-o
2 participants
@lkocman @agraul