Add show-backlog command #168
Conversation
There was a problem hiding this comment.
@matheussbernardo thanks a lot for your PR! 😍
As commented in #45 (comment), forget about the velocity and just focus on the command. 😄
I have made some comments, if you have doubts or comments, please do not hesitate to ask! 😄
lib/cli.rb
Outdated
| option 'board-id', desc: 'Id of Trello board', required: true | ||
| def show_backlog | ||
| puts 'Title' | ||
| TrelloWrapper.new(@@settings).board(options['board-id']).sprint_backlog_column.cards.each do |card| |
There was a problem hiding this comment.
if I am not wrong, this should be planning_backlog_column and not sprint_backlog_column.
@cornelius wrote in #45 (comment):
When doing sprint commitments we need a way to see the whole backlog in one view.
Normally when preparing the next Sprint in a team using Scrum, you have to decide how many task the team is able to do in the Sprint. That why I think this is in the planning board and not in the sprint one. @cornelius is that right?
Note: A sprint can be for example two week. The team decide at the start what they are going to work in this two week. @matheussbernardo if you think it would be useful to read more about how scrum works, please tell me and I will send you some material. 😉
There was a problem hiding this comment.
Also, what about writing this like:
trello = TrelloWrapper.new(@@settings)
board = trello.board(board_id(options['board-id']))
board.planning_backlog_column.cards.each do |card|More readable when splitting it 😉
lib/cli.rb
Outdated
| desc 'show-backlog', 'Show backlog of board' | ||
| option 'board-id', desc: 'Id of Trello board', required: true | ||
| def show_backlog | ||
| puts 'Title' |
lib/scrum_board.rb
Outdated
| @@ -12,6 +12,10 @@ def columns | |||
| @columns ||= @board_data['lists'].map{|x| Column.new(@board_data, x['id'], @settings)} | |||
| end | |||
|
|
|||
| def sprint_backlog_column | |||
| columns.select{ |col| col.name == 'Sprint Backlog' }.first | |||
There was a problem hiding this comment.
I would prefer to write column instead of col, more explicit 😉
The column name can be configured, as you can see in the Documentation, so you should use settings.list_names['planning_backlog'] 😄
There was a problem hiding this comment.
Hello @Ana06, the method list_names does not exist in the setting object, what I did was @settings.scrum['list_names']['planning_backlog']
|
Yes, this is about the backlog on the planning board. |
|
@Ana06 I updated as requested. |
|
@matheussbernardo do you need help? The code is already great, we just need a test and we can 🚢 it! 😉 |
|
@Ana06 Sorry for the delay, I was on vacation! I added the requested spec. Is there anything else to do? |
There was a problem hiding this comment.
@Ana06 Sorry for the delay, I was on vacation! I added the requested spec. Is there anything else to do?
It is fine, I just wanted to know if you needed help 😉 The code looks great! 😍 Can you please squash your commits? that there is only one commit (two if you want to have the test separated).
The commit should include a title (Add show-backlog command) a description and the issue it is closing. 😉
matheussbernardo
force-pushed
the
master
branch
5 times, most recently
from
e7d55ae
to
116ce39
Compare
|
@Ana06 Is the squash correct? I`m having a hard time with git rebase -i. |
It doesn't seem so 😭 Try with: And then push it again. This should remove the current commits that are in your PR and that are not yours. In case that this doesn't work and you don't manage to solve it, you can also ping me in IRC on Freenode (normally my nick is @Ana06, although sometimes it has a random number of 0s). Maybe easier 😉. |
…g backlog, it closes issue openSUSE#45
|
@Ana06 It worked! Hope we can 🚢 it now! |
There was a problem hiding this comment.
@Ana06 It worked! Hope we can :ship: it now!
🎉
Normally the description should go in a different line, so it should look like:
Add show-backlog command
It creates a command that shows the planning backlog.
It closes issue #45.
But it is not that important, let's merge it. For future commits, you can read: https://github.com/RomuloOliveira/commit-messages-guide
Great work! 💐
This PR starts to work on #45,
I've created a method on ScrumBoard to get the Sprint Backlog Column and then on the CLI I created the command and printed the information.
The --velocity option on the #45 is WIP.