dbus: Cleanup the dbus-service.h file and corresponding makros #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomaschewski
changed the title
mtomaschewski
force-pushed
the
dbus-service-macros
branch
2 times, most recently
from
6db51ab
to
24c1983
Compare
1) remove the unused .parse() function to gain the possibility to specify the
`PROPERTY` makros with `SET_FN` or `GET_FN` to define only `.get` or `.set`
handler function, e.g.:
```NI_DBUS_GENERIC_BYTE_ARRAY_PROPERTY(bss, IEs, ies, SET_FN)```.
- `SET_FN` => from DBus to C
- `GET_FN` => from C to DBus
2) remove the unused `rw` argument from `NI_DBUS_GENERIC_DICT_PROPERTY`.
From gitlab merge request wicked-maintainers/wicked!167 by Clemens Famulla-Conrad
mtomaschewski
force-pushed
the
dbus-service-macros
branch
from
24c1983
to
68fc342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROPERTYmakros withSET_FNorGET_FNto define only.getor.sethandler function, e.g.:
NI_DBUS_GENERIC_BYTE_ARRAY_PROPERTY(bss, IEs, ies, SET_FN).SET_FN=> from DBus to CGET_FN=> from C to DBusrwargument fromNI_DBUS_GENERIC_DICT_PROPERTY.From gitlab merge request wicked-maintainers/wicked!167 by Clemens Famulla-Conrad