Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Capacity limit for IndividualFacilityUse and use of Harvest Start Time #246

Merged
merged 10 commits into from
Oct 15, 2020
Merged

fix: Capacity limit for IndividualFacilityUse and use of Harvest Start Time #246

merged 10 commits into from
Oct 15, 2020

Conversation

nickevansuk
Copy link
Collaborator

@nickevansuk nickevansuk commented Oct 14, 2020 •
edited
Loading

Fixes these issues:

  • IndividualFacilityUse is not allowed Slot with remainingUses of greater than one, which causes issues with "multiple" opportunity tests (Tests should run for single occupancy booking systems #236)
  • Additionally the current time is referenced in test-interface-criteria which makes the bucket allocation inconsistent between harvesting and the test run.

@nickevansuk
Copy link
Collaborator Author

nickevansuk commented Oct 15, 2020 •
edited
Loading

Note this also includes a fix for #237, for expediency

@nickevansuk nickevansuk merged commit 7e02bc9 into master Oct 15, 2020
@nickevansuk nickevansuk deleted the fix/capacity-limit-and-harvest-start-time branch October 15, 2020 10:35
@nickevansuk nickevansuk mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehesluke lukehesluke lukehesluke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickevansuk @lukehesluke