Fix Json Errors #133

tomirons · 2023-05-31T15:13:50Z

Fixes #132

tomirons · 2023-05-31T15:20:11Z

src/Transporters/HttpTransporter.php

@@ -113,7 +113,7 @@ private function throwIfJsonError(ResponseInterface $response, string|ResponseIn
            return;
        }

-        if ($response->getheader('Content-Type')[0] !== 'application/json; charset=utf-8') {
+        if (! in_array($response->getheader('Content-Type')[0], ['application/json', 'application/json; charset=utf-8'])) {


A simpler fix would be to do this. But I'm uncertain if there consequences.

Suggested change

if (! in_array($response->getheader('Content-Type')[0], ['application/json', 'application/json; charset=utf-8'])) {

if ($response->getheader('Content-Type')[0] !== 'application/json') {

gehrisandro · 2023-06-01T04:27:38Z

closed in favour of #134

update conditional

599f92e

tomirons commented May 31, 2023

View reviewed changes

gehrisandro closed this Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Json Errors #133

Fix Json Errors #133

tomirons commented May 31, 2023

tomirons May 31, 2023

gehrisandro commented Jun 1, 2023

	if (! in_array($response->getheader('Content-Type')[0], ['application/json', 'application/json; charset=utf-8'])) {
	if ($response->getheader('Content-Type')[0] !== 'application/json') {

Fix Json Errors #133

Fix Json Errors #133

Conversation

tomirons commented May 31, 2023

tomirons May 31, 2023

Choose a reason for hiding this comment

gehrisandro commented Jun 1, 2023