Add default system_fingerprint to completion create response fixture #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, but it looks like this field is not included in a completion response. I know, the OpenAI docs says, that it should be included, but I was not able to see this field in a test request and I don't think OpenAI has actually added it, as the completion API is already deprecated. Have you an evidence, that there actually is a |
|
Closed due to inactivity. Feel free to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
This PR continues from #308 by also adding the
system_fingerprintfield to the Completions fixture andCreateResponseclass. This allows the field to be set via theCreateResponse.fakemethod, which has been included in the"fake with override"Completion's test.Related: