Fixed broken getting of body as a string #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamCampbell Any chance of having a test on this? |
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
Jun 13, 2023
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
Aug 15, 2023
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
Oct 24, 2023
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
Nov 8, 2023
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
Feb 28, 2024
awm1
pushed a commit
to awm1/openai-php-client
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
->getContents()only reads the stream from wherever the current position is - it does not rewind it. This can be hugely problematic if, for example, a logging middleware is attached to the client, which leaves the pointer not at the start of the stream/