Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing attributes for assistant streaming #392

Merged
merged 1 commit into from
May 21, 2024
Merged

Handle missing attributes for assistant streaming #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Responses/Threads/Runs/Steps/Delta/ThreadRunStepDeltaResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ final class ThreadRunStepDeltaResponse implements ResponseContract
use Fakeable;

private function __construct(
public string $id,
public ?string $id,
public string $object,
public ThreadRunStepDeltaObject $delta,
) {
Expand All @@ -35,7 +35,7 @@ private function __construct(
public static function from(array $attributes): self
{
return new self(
$attributes['id'],
$attributes['id'] ?? null,
$attributes['object'],
ThreadRunStepDeltaObject::from($attributes['delta']),
);
Expand Down
4 changes: 2 additions & 2 deletions src/Responses/Threads/Runs/Steps/ThreadRunStepResponseFunction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ final class ThreadRunStepResponseFunction implements ResponseContract
use Fakeable;

private function __construct(
public string $name,
public ?string $name,
public string $arguments,
public ?string $output,
) {
Expand All @@ -35,7 +35,7 @@ private function __construct(
public static function from(array $attributes): self
{
return new self(
$attributes['name'],
$attributes['name'] ?? null,
$attributes['arguments'],
$attributes['output'] ?? null,
);
Expand Down
4 changes: 2 additions & 2 deletions src/Responses/Threads/Runs/Steps/ThreadRunStepResponseFunctionToolCall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class ThreadRunStepResponseFunctionToolCall implements ResponseContract
* @param 'function' $type
*/
private function __construct(
public string $id,
public ?string $id,
public string $type,
public ThreadRunStepResponseFunction $function,
) {
Expand All @@ -38,7 +38,7 @@ private function __construct(
public static function from(array $attributes): self
{
return new self(
$attributes['id'],
$attributes['id'] ?? null,
$attributes['type'],
ThreadRunStepResponseFunction::from($attributes['function']),
);
Expand Down