Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bullet extra, constrain gym version to be >= 0.10.0 #885

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

pzhokhov
Copy link
Collaborator

No description provided.

Copy link
Contributor

@christopherhesse christopherhesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment

setup.py Outdated
@@ -32,7 +29,7 @@
packages=[package for package in find_packages()
if package.startswith('baselines')],
install_requires=[
'gym',
'gym>=0.10.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about gym~=0.10.0? Only difference is it would not automatically upgrade to 0.11.0 and potentially break.

@pzhokhov pzhokhov merged commit 3301089 into master Apr 26, 2019
@pzhokhov pzhokhov deleted the fix_gym_version branch April 26, 2019 23:14
kkonen pushed a commit to kkonen/baselines-1 that referenced this pull request Sep 26, 2019
* remove bullet extra, constrain gym version to be >= 0.10.0

* constrain gym version from above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants