-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL pgvector datastore #45
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2023
Closed
isafulf
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for adding! Left some comments.
A few things:
- Could you make sure that the functionality of the implementation of the datastore functions is consistent with the other implementations (specifically, supporting querying with filters and deleting with filters)?
- Also, some more detail in the setup instructions in the readme would be great.
- Have you run this to verify that your implementation works?
- Could you consider adding integration tests, similar to the integration tests for the other vector dbs in the tests folder?
- I have referred you as a tester for developer plugins, once you are off the waitlist it would be great if you could test the retrieval plugin with pgvector end to end.
To anyone else reading this -- feel free to contribute to the PR.
Thanks for the review @isafulf! |
kiwicopple
reviewed
May 11, 2023
kiwicopple
reviewed
May 11, 2023
kiwicopple
reviewed
May 11, 2023
kiwicopple
reviewed
May 11, 2023
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36 by adding PostgreSQL pgvector as a datastore option.
JSONB
field for metadata