Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL pgvector datastore #45

Closed
wants to merge 16 commits into from

Conversation

mmmaia
Copy link

@mmmaia mmmaia commented Mar 25, 2023

Closes #36 by adding PostgreSQL pgvector as a datastore option.

image

Copy link
Collaborator

@isafulf isafulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for adding! Left some comments.

A few things:

  • Could you make sure that the functionality of the implementation of the datastore functions is consistent with the other implementations (specifically, supporting querying with filters and deleting with filters)?
  • Also, some more detail in the setup instructions in the readme would be great.
  • Have you run this to verify that your implementation works?
  • Could you consider adding integration tests, similar to the integration tests for the other vector dbs in the tests folder?
  • I have referred you as a tester for developer plugins, once you are off the waitlist it would be great if you could test the retrieval plugin with pgvector end to end.

To anyone else reading this -- feel free to contribute to the PR.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Outdated Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Outdated Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Outdated Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Outdated Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Show resolved Hide resolved
datastore/providers/pgvector_datastore.py Outdated Show resolved Hide resolved
@mmmaia
Copy link
Author

mmmaia commented Mar 30, 2023

Thanks for the review @isafulf!
I addressed your comments and will run an end-to-end test of the plugin soon.

@mmmaia mmmaia requested a review from isafulf March 31, 2023 20:30
@mmmaia mmmaia changed the title Add pgvector datastore Add PostgreSQL pgvector datastore Apr 12, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mmmaia and others added 4 commits May 15, 2023 12:38
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
Co-authored-by: Copple <10214025+kiwicopple@users.noreply.github.com>
@mmmaia mmmaia closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pgvector data store
4 participants