Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argparse.BooleanOptionalAction is not available in Python 3.8 #51

Closed
hh-19 opened this issue Mar 14, 2023 · 1 comment
Closed

argparse.BooleanOptionalAction is not available in Python 3.8 #51

hh-19 opened this issue Mar 14, 2023 · 1 comment

Comments

@hh-19
Copy link

hh-19 commented Mar 14, 2023

argparse.BooleanOptionalAction is used in the module, for example, in evals/cli/oaieval.py. However, BooleanOptionalAction was not added till Python 3.9.

The Python version requirements in the pyproject.toml is specified as

evals/pyproject.toml

Line 4 in b297ecd

requires-python = ">=3.8"

Might this require changing?
@Xmaster6y
Copy link

They could be replaced by action='store_true' to ensure compatibility, but I am not sure this is worth the pain.

andrew-openai pushed a commit that referenced this issue Mar 21, 2023
@andremafei
Fixes issue #155 and #51 (#310)
f118fca 
Min Python version is actually 3.9 not 3.8 as is says in
"pyproject.toml".
@jwang47 jwang47 closed this as completed Mar 28, 2023
Linmj-Judy pushed a commit to TablewareBox/evals that referenced this issue Feb 27, 2024
@andremafei
Fixes issue openai#155 and openai#51 (openai#310)
e5de90d 
Min Python version is actually 3.9 not 3.8 as is says in
"pyproject.toml".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwang47 @hh-19 @Xmaster6y