Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seeding utils as NumPy 1.17 supports better random number generators #1663

Closed
zuoxingdong opened this issue Aug 28, 2019 · 3 comments
Closed

Remove seeding utils as NumPy 1.17 supports better random number generators #1663

zuoxingdong opened this issue Aug 28, 2019 · 3 comments
Labels
help wanted

Comments

@zuoxingdong
Copy link
Contributor

In the release of Numpy 1.17, it seems that it has improvement in seeding designed for parallel processes.

I am curious about if it could be a good idea to remove the seeding utils which was originally designed for reducing correlation due to weak seeding (Python 2 in particular) ?

What do you think ? @pzhokhov @christopherhesse
@christopherhesse
Copy link
Contributor

I'm not sure we want to require numpy 1.17 just yet, maybe wait until it has been out for a while.

Judenseth added a commit to cmontrond/gym that referenced this issue Apr 24, 2020
@Judenseth
Second Issue solved and working on issue openai#1663
00a2963
Judenseth added a commit to cmontrond/gym that referenced this issue Apr 24, 2020
@Judenseth
Solved issues openai#661, openai#1698, openai#1663, openai#1847, open…
bfaa92f 
…ai#1770
Judenseth added a commit to cmontrond/gym that referenced this issue May 4, 2020
@Judenseth
Solved issues openai#661, openai#1698, openai#1663, openai#1847, open…
68394b8 
…ai#1770
Judenseth added a commit to cmontrond/gym that referenced this issue May 4, 2020
@Judenseth
Solved issues openai#661, openai#1698, openai#1663, openai#1847, open…
75efbe6 
…ai#1770
@jkterry1
Copy link
Collaborator

Numpy 1.17 can safely be required now

This was referenced Sep 25, 2021
Closed
Merged
@jkterry1
Copy link
Collaborator

Closing in favor of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christopherhesse @zuoxingdong @jkterry1