Drop python2 support #1819
Drop python2 support #1819
Conversation
This reverts commit 43ceabf.
|
Also I'm a little worried that the 3.8 tests are segfaulting, can just the mujoco ones be disabled? |
|
Should we remove importing that involves |
|
|
@christopherhesse I think removing six should be its own, bigger PR, because it is used in a bunch of places. Created an issue (#1823) for that. |
yeah, but let's do that in a separate PR (maybe the same one that removes six - I added removal of these imports to #1823 issue as well) |
| @@ -45,11 +45,10 @@ | |||
| tests_require=['pytest', 'mock'], | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*', | |||
There was a problem hiding this comment.
I think you'd want to update python_requires as well, otherwise as soon as you add Python code that is not Py2-compatible, you will break Python 2 users who don't set an upper bound on your dependency (gym>=0.10), or expect compatibility w.r.t. semantic versioning (gym>=0.15, <1.0 for example) - note that this is a minor version change as per VERSION = '0.17.0'
There was a problem hiding this comment.
good point, thanks!
There was a problem hiding this comment.
Hey @cclauss , I've seen your drive-by comments on quite a few projects re: Python 3 migration. FYI - this is a common error when dropping Py2. Another project I saw this: hamcrest/PyHamcrest#131. Perhaps this is something to keep an eye on in the projects that you come across.
There was a problem hiding this comment.
I would use the python_requires=">=3.5" approach when dropping legacy Python.
Like #1827 has done.
There was a problem hiding this comment.
Yeah, fully agree; I meant that more projects should be following this pattern, and I thought perhaps you are in the position to raise awareness of the proper way to drop Py2 support in other projects.
* drop python 2 support * remove python 2.7 logic from Dockerfile * Revert "remove python 2.7 logic from Dockerfile" This reverts commit 43ceabf. * remove python 2.7 logic from Dockerfile * use python 3.7.3 (3.7.6 segfaults with mujoco for some reason? * include cmake into system level packages * add swig to system packages * python3.8 build still segfaults on mujoco tests, disabling for now * add python 3.8 and 3.9 to the build * python 3.9.1 -> 3.9.0 * oops i did not realize python 3.9 is still in alpha
No description provided.