Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescale observation wrapper #1940

Closed
wants to merge 6 commits into from
Closed

Rescale observation wrapper #1940

wants to merge 6 commits into from

Conversation

hartikainen
Copy link
Contributor

Closes #1939

@instance01
Copy link
Contributor

Hey, you should check that unit tests are running. Try pytest locally and see if something in your code gets caught.

pzhokhov
pzhokhov reviewed Jun 19, 2020
View reviewed changes
gym/wrappers/rescale_observation.py

For `Box` spaces, `low` and `high` can be either scalar or vector, and
will be broadcasted according to numpy broadcasting rules. For `Tuple`
and `Dict` spaces, both `low` and `high` are expected to be scalar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you specify in the docstring that elements of Tuple or Dict space are expected to be Box?

@pzhokhov
Copy link
Collaborator

Thanks for the PR @hartikainen! Looks good, but I would add

  1. an explanation about are allowed types of sub-spaces in case of Dict or Tuple space
  2. (if you think that could be useful) recursive rescaling logic to allow elements of Dict or Tuple to be Dict or Tuple

@pzhokhov pzhokhov self-assigned this Jun 19, 2020
@jkterry1
Copy link
Collaborator

I'm closing this per #2259

@jkterry1 jkterry1 closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzhokhov pzhokhov pzhokhov left review comments

Assignees

@pzhokhov pzhokhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: observation space rescale wrapper
4 participants
@hartikainen @instance01 @pzhokhov @jkterry1