Mark abstract methods as abstract #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewer: @vwxyzjn |
|
This seems to be a pretty straightforward fix. @jkterry1 LGTM. |
|
@jakkes can you please make the linting tests pass before I merge this? |
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Sep 6, 2021
Co-authored-by: J K Terry <justinkterry@gmail.com>
|
Thanks for taking care of it and merging :) The gym class should probably be made to inherit from |
|
@jakkes try doing a PR for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not marking abstract methods as abstract causes some code analysers (e.g. PyLance) to not identify the method properly. In this PR, I marked all abstract method of the base environment classes as abstract.
Fixes #2136