-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeding update #2422
Merged
Merged
Seeding update #2422
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
1281c86
Ditch most of the seeding.py and replace np_random with the numpy def…
RedTachyon ac7deaf
Updated a bunch of RNG calls from the RandomState API to Generator API
RedTachyon 5708b25
black; didn't expect that, did ya?
RedTachyon 4c5aac9
Undo a typo
RedTachyon 8e20eec
blaaack
RedTachyon d3eeb91
More typo fixes
RedTachyon c0e4d41
Fixed setting/getting state in multidiscrete spaces
RedTachyon cccbff8
Fix typo, fix a test to work with the new sampling
RedTachyon 2e912da
Correctly (?) pass the randomly generated seed if np_random is called…
RedTachyon bed3b89
Convert the Discrete sample to a python int (as opposed to np.int64)
RedTachyon fd0ad83
Remove some redundant imports
RedTachyon 173eb20
First version of the compatibility layer for old-style RNG. Mainly to…
RedTachyon e93530e
Removed redundant f-strings
RedTachyon a264291
Style fixes, removing unused imports
RedTachyon 9646854
Merge branch 'master' into seeding-update
RedTachyon be258f9
Merge branch 'openai:master' into seeding-update
RedTachyon ddbbfc3
Try to make tests pass by removing atari from the dockerfile
RedTachyon 0cfb474
Try to make tests pass by removing atari from the setup
RedTachyon 74bf50d
Try to make tests pass by removing atari from the setup
RedTachyon 0fb36dc
Try to make tests pass by removing atari from the setup
RedTachyon ce9e6a5
First attempt at deprecating `env.seed` and supporting `env.reset(see…
RedTachyon 9995533
black; didn't expect that, didya?
RedTachyon 4e54c9c
Rename the reset parameter in VecEnvs back to `seed`
RedTachyon 24a6087
Updated tests to use the new seeding method
RedTachyon 18f99df
Removed a bunch of old `seed` calls.
RedTachyon 45a4d05
Stop Discrete envs from doing part of the setup (and using the random…
RedTachyon 0df2174
Add explicit seed to wrappers reset
RedTachyon f9ae0d6
Remove an accidental return
RedTachyon d171f17
Re-add some legacy functions with a warning.
RedTachyon 9d237a8
Use deprecation instead of regular warnings for the newly deprecated …
RedTachyon bbc3cc7
Merge branch 'master' into seeding-update
RedTachyon 5547289
Merge branch 'master' into seeding-update
RedTachyon 202b808
Merge branch 'master' into seeding-update
RedTachyon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark
seed
as a keyword-only argument. Same modification for all subclasses.