Add py.typed to package_data #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I sat down and tried to read the specification you linked to, and I very clearly don't understand something critical about what's going on here. I'm going to have Jesse review this. |
|
https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/ This is a nice tl;dr of the thing. Overall this PR seems alright and should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is described in https://peps.python.org/pep-0561/#packaging-type-information
I think this will close #2682 but haven't released anything using this feature before myself