Automatic evaluation of cfrc_ext #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See openai/gym#1541 (comment) @krzentner Hi! Looks like you've been through the same hoops in did, only a year earlier, and found @AlexanderGri's code as well. Could you try rebasing this just so CI turns green? This might help move this along... |
|
Unfortunately this PR is not from my fork (yes, Github allows you to make PRs between two repos you have no control over). However, I have created PR #659 which replaces this one and is rebased as requested. |
Yes I know and acknowledged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to merge this change? It should prevent openai/gym from producing incorrect results when mujoco 2 is used (which many people are doing in practice).