Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create How to combine GPTV with RAG - Create a Clothing Matchmaker App #1047

Merged
merged 19 commits into from
Feb 16, 2024

Conversation

teomusatoiu
Copy link
Contributor

@teomusatoiu teomusatoiu commented Feb 13, 2024

Summary

Briefly describe the changes and the goal of this PR. Make sure the PR title summarizes the changes effectively.

Motivation

Why are these changes necessary? How do they improve the cookbook?


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • I have conducted a self-review of my content based on the contribution guidelines:
    • Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • Correctness: The information I include is correct and all of my code executes successfully.
    • Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

@teomusatoiu teomusatoiu marked this pull request as draft February 13, 2024 13:15
@teomusatoiu teomusatoiu marked this pull request as ready for review February 13, 2024 14:02
@katia-openai
Copy link
Contributor

First of all great notebook, easy to follow!

A few comments:

  • I would add in the introduction a generalization paragraph: what could this be used for in addition to this specific use case? why use this approach instead of another one?
  • The paragraph after generating the embeddings that starts with "The next line will create..." has strikethrough text which makes it hard to understand
  • I would also make it clearer that there is 2 options with H4 text or something - so that people don't accidentally run the cell if they don't want to
  • Small nit but I would rename the "embedding" parameter in find_similar_items to "input_embedding" to differentiate from the "embeddings" parameters
  • In the analyze_image function, there's a typo in the example output: "itmes" > "items"
  • The path to the images is not correct "data/clothes/images/" > "data/sample_clothes/sample_images" - it appears in 2 locations
  • Not sure I understand the feedback loop part: how would you implement this?
  • The pricing part in the conclusion is not displayed correctly

Thanks Teo, this could be a great addition to our Recommendations content!

@teomusatoiu
Copy link
Contributor Author

Thanks @katia-openai ! I adjusted the notebook to fix your comments. Let me know if there's anything else !

@teomusatoiu teomusatoiu merged commit d4a3e14 into main Feb 16, 2024
@teomusatoiu teomusatoiu deleted the teo/gptv_and_rag branch February 16, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants